Mobile site editor header toolbar button bugfix #58852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The site hub icon was full width at smaller screens, obstructing the icons in the toolbar from being clicked.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
the
[Feature] Site Editor
|
Size Change: -22 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes bug where top toolbar buttons are unresponsive on mobile. I believe this was caused by https://github.com/WordPress/gutenberg/pull/57938/files#diff-b948436daf4637baf6bada5f65931d841feed7039369fba4176b1afb23d497f4L17-L33, so I undid some of it.
Closes #58781
Why?
Mobile should function as per desktop and all elements of top toolbar shoulld be interactive.
How?
The site hub icon was full width at smaller screens, obstructing the icons in the toolbar from being clicked.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-02-08.at.16-55-41.mp4
Co-authored-by: getdave get_dave@git.wordpress.org